Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(medusa): Improve database loader error handling #4254

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jun 6, 2023

FIXES CORE-1400

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 48b1443

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-mailchimp Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Jun 7, 2023 8:32am

@adrien2p adrien2p marked this pull request as ready for review June 6, 2023 08:11
@adrien2p adrien2p requested a review from a team as a code owner June 6, 2023 08:11
@adrien2p adrien2p force-pushed the chore/database-loader-error-handling branch from 2d0d3d2 to b8aa517 Compare June 6, 2023 08:11
@adrien2p adrien2p requested a review from a team as a code owner June 6, 2023 08:11
@adrien2p adrien2p requested a review from olivermrbl June 6, 2023 08:17
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we place this in utils to make it reusable in our modules?

@adrien2p adrien2p force-pushed the chore/database-loader-error-handling branch from ffda161 to 67e762a Compare June 6, 2023 09:13
@adrien2p adrien2p requested a review from olivermrbl June 6, 2023 09:13
@adrien2p adrien2p force-pushed the chore/database-loader-error-handling branch from 67e762a to 42000f3 Compare June 6, 2023 12:22
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this!

Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ Oli's changes 😄

@olivermrbl
Copy link
Contributor

Unit tests need updating 👍

@olivermrbl olivermrbl merged commit 2db6a1d into develop Jun 7, 2023
@olivermrbl olivermrbl deleted the chore/database-loader-error-handling branch June 7, 2023 08:57
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
olivermrbl pushed a commit that referenced this pull request Jun 14, 2023
* chore(medusa): Improve database loader error handling

* Create sharp-melons-doubt.md

* move the database error handling to the utils

* fix unit tests

* tackle feedback

* fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants